[webkit-reviews] review denied: [Bug 228768] Support WTF logging channels : [Attachment 434896] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 228768: Support WTF logging channels
https://bugs.webkit.org/show_bug.cgi?id=228768

Attachment 434896: Patch

https://bugs.webkit.org/attachment.cgi?id=434896&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 434896
  --> https://bugs.webkit.org/attachment.cgi?id=434896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434896&action=review

r- to remove code duplicated between WTF, WebCore and WebKit.

> Source/WTF/wtf/Logging.h:57
> +WTF_EXPORT_PRIVATE String logLevelString();
> +bool isLogChannelEnabled(const String& name);
> +WTF_EXPORT_PRIVATE void setLogChannelToAccumulate(const String& name);
> +WTF_EXPORT_PRIVATE void clearAllLogChannelsToAccumulate();
> +WTF_EXPORT_PRIVATE void
initializeLogChannelsIfNecessary(std::optional<String> = std::nullopt);

I think you should follow WebCore and put these in LogInitialization.h (there
was a reason I split things into two headers, but I forget what it was).

I think you can also remove the WebCore and WebKit implementations of these
functions, sharing all the code from WTF.