[webkit-reviews] review granted: [Bug 228766] [Cocoa] Tweak the formatting for passing NSArrays to TextStreams : [Attachment 434891] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 08:56:44 PDT 2021

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 228766: [Cocoa] Tweak the formatting for passing NSArrays to TextStreams

Attachment 434891: Patch


--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 434891
  --> https://bugs.webkit.org/attachment.cgi?id=434891

View in context: https://bugs.webkit.org/attachment.cgi?id=434891&action=review

> Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.mm:71
> +    // Intentionally don't cast to id<NSObject> because we want to make sure
that this can be called from raw C++ code.

But this is a .mm file so is being complied as ObjC++. Wouldn't a proper test
be in a .cpp file?

More information about the webkit-reviews mailing list