[webkit-reviews] review granted: [Bug 228747] fast/canvas/canvas-crash.html doesn't test what it intends to on iOS : [Attachment 434850] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 228747: fast/canvas/canvas-crash.html doesn't test what it intends to on
iOS
https://bugs.webkit.org/show_bug.cgi?id=228747

Attachment 434850: Patch

https://bugs.webkit.org/attachment.cgi?id=434850&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 434850
  --> https://bugs.webkit.org/attachment.cgi?id=434850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434850&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:115
> +static size_t maxCanvasAreaForTesting;
> +static size_t maxActivePixelMemoryForTesting;

Could these be Markable<>?

> Source/WebCore/testing/Internals.cpp:604
> +    HTMLCanvasElement::setMaxPixelMemoryForTesting(0);
> +    HTMLCanvasElement::setMaxCanvasAreaForTesting(0);

Ideally these would take std::optionals