[webkit-reviews] review granted: [Bug 228737] Crash while reading WebGL drawing buffer if canvas image buffer allocation fails : [Attachment 434827] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 228737: Crash while reading WebGL drawing buffer if canvas image buffer
allocation fails
https://bugs.webkit.org/show_bug.cgi?id=228737

Attachment 434827: Patch

https://bugs.webkit.org/attachment.cgi?id=434827&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 434827
  --> https://bugs.webkit.org/attachment.cgi?id=434827
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434827&action=review

Looks good! r=me

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1221
> +	       if (auto buffer = base.buffer()) {

Is a nullptr buffer something we should report in a log message or something?
Or perhaps that allocation failure is logged elsewhere?