[webkit-reviews] review granted: [Bug 228290] [WPE][GTK] SVN_REVISION drifting away if bots don't re-run cmake : [Attachment 434822] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 228290: [WPE][GTK] SVN_REVISION drifting away if bots don't re-run cmake
https://bugs.webkit.org/show_bug.cgi?id=228290

Attachment 434822: Patch

https://bugs.webkit.org/attachment.cgi?id=434822&action=review




--- Comment #16 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 434822
  --> https://bugs.webkit.org/attachment.cgi?id=434822
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434822&action=review

> Tools/glib/apply-build-revision-to-files.py:50
> +	       print("Processing {} as it is, $BUILD_REVISION might not be
expanded as expected.".format(in_file))

I would return a failure status here. You don't want the build to succeed if
the revision isn't really updated, do you? That would have caught this sooner!