[webkit-reviews] review granted: [Bug 228708] [App Privacy Report] Domains are deleted for ephemeral website data stores : [Attachment 434797] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 228708: [App Privacy Report] Domains are deleted for ephemeral website data
stores
https://bugs.webkit.org/show_bug.cgi?id=228708

Attachment 434797: Patch

https://bugs.webkit.org/attachment.cgi?id=434797&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 434797
  --> https://bugs.webkit.org/attachment.cgi?id=434797
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434797&action=review

r=me

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1830
> +    if (sessionID().isEphemeral()) {

Could you add a radar link where you requested SPI to add an automated test for
this?
// FIXME: Add automated test for this once rdar://???????? is resolved.