[webkit-reviews] review granted: [Bug 228613] [JSC] Yarr BoyerMoore search should support character-class : [Attachment 434773] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 228613: [JSC] Yarr BoyerMoore search should support character-class
https://bugs.webkit.org/show_bug.cgi?id=228613

Attachment 434773: Patch

https://bugs.webkit.org/attachment.cgi?id=434773&action=review




--- Comment #14 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 434773
  --> https://bugs.webkit.org/attachment.cgi?id=434773
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434773&action=review

r=me

>>> Source/JavaScriptCore/yarr/YarrJIT.h:122
>>> +	     m_count = mapSize;
>> 
>> we don't need to set the actual bits?
> 
> This map-count value is used to check whether we should care this bitmap in
`findBestCharacterSequence`. So by setting it to mapSize, we can say "the
collected characters are not sure, but this map is not useful".

can we static assert that the limit is <= mapSize?