[webkit-reviews] review granted: [Bug 228701] [PlayStation] Make C files in testapi compile with a C standard rather than C++ one : [Attachment 434759] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 12:04:28 PDT 2021


Ross Kirsling <ross.kirsling at sony.com> has granted Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 228701: [PlayStation] Make C files in testapi compile with a C standard
rather than C++ one
https://bugs.webkit.org/show_bug.cgi?id=228701

Attachment 434759: Patch

https://bugs.webkit.org/attachment.cgi?id=434759&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 434759
  --> https://bugs.webkit.org/attachment.cgi?id=434759
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434759&action=review

r=me

> Source/JavaScriptCore/shell/PlatformPlayStation.cmake:34
> +	   PROPERTIES COMPILE_FLAGS --std=gnu17

I take it the GNU extensions are needed?


More information about the webkit-reviews mailing list