[webkit-reviews] review denied: [Bug 228697] Replace webkit- prefix properties with Standard Properties in Source/ : [Attachment 434747] Patch

[bugzilla-daemon at webkit.org]

Sam Sneddon [:gsnedders] <gsnedders at apple.com> has denied Sonia Singla
<soniasingla.1812 at gmail.com>'s request for review:
Bug 228697: Replace webkit- prefix properties with Standard Properties in
Source/
https://bugs.webkit.org/show_bug.cgi?id=228697

Attachment 434747: Patch

https://bugs.webkit.org/attachment.cgi?id=434747&action=review




--- Comment #2 from Sam Sneddon [:gsnedders] <gsnedders at apple.com> ---
Comment on attachment 434747
  --> https://bugs.webkit.org/attachment.cgi?id=434747
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434747&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:414
> -    -webkit-margin-start: 16px;
> +    margin-block-start: 16px;

You've consistently changed -webkit-margin-start to margin-block-start, but it
should be margin-inline-start. I suspect this accounts for all the failures on
EWS.