[webkit-reviews] review canceled: [Bug 228691] Skip unnecessary invalidation of document level NodeList caches : [Attachment 434727] For EWS testing only

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 1 14:58:53 PDT 2021


Maciej Stachowiak <mjs at apple.com> has canceled Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 228691: Skip unnecessary invalidation of document level NodeList caches
https://bugs.webkit.org/show_bug.cgi?id=228691

Attachment 434727: For EWS testing only

https://bugs.webkit.org/attachment.cgi?id=434727&action=review




--- Comment #2 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 434727
  --> https://bugs.webkit.org/attachment.cgi?id=434727
For EWS testing only

Not for landing. This version of the patch is like incorrect, as some NodeLists
or Collections may need document-level invalidation even when the node isn't in
the document. This is probably true for HTMLFormControlCollection, not clear
what else may be affected. Testing if this builds and passes tests for now.


More information about the webkit-reviews mailing list