[webkit-reviews] review granted: [Bug 225260] App highlight UI should be disabled when selecting text in image overlays : [Attachment 427471] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 225260: App highlight UI should be disabled when selecting text in image
overlays
https://bugs.webkit.org/show_bug.cgi?id=225260

Attachment 427471: Patch

https://bugs.webkit.org/attachment.cgi?id=427471&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 427471
  --> https://bugs.webkit.org/attachment.cgi?id=427471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427471&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3571
> +	   // FIXME: It doesn't seem like this codepath is exercised, since
UIKit only asks for the action target for custom actions
> +	   // added via -[UIMenuController setMenuItems:]. Can we remove this
check?

Yikes, good catch.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3769
> +	   return state.selectionIsRange && !state.isContentEditable &&
!state.selectionIsRangeInsideImageOverlay ? self : nil;

Please factor this out as discussed.

> Tools/ChangeLog:21
> +	   Add support for a new `TestOption` that enables app higlights. See
the new layout test for more information.

sp. "highlights"