[webkit-reviews] review requested: [Bug 225259] [iOS] Crash when tapping fields on cycle.travel : [Attachment 427475] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 30 18:24:06 PDT 2021


Tim Horton <thorton at apple.com> has asked  for review:
Bug 225259: [iOS] Crash when tapping fields on cycle.travel
https://bugs.webkit.org/show_bug.cgi?id=225259

Attachment 427475: Patch

https://bugs.webkit.org/attachment.cgi?id=427475&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 427475
  --> https://bugs.webkit.org/attachment.cgi?id=427475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427475&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3080
> +Optional<FocusedElementInformation> WebPage::getFocusedElementInformation()

if it's not out-arg-y, this should not have a get- prefix


More information about the webkit-reviews mailing list