[webkit-reviews] review granted: [Bug 225218] _WKWebAuthenticationPanelDelegate registration and assertion SPI doesn't work without an LAContext : [Attachment 427387] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 225218: _WKWebAuthenticationPanelDelegate registration and assertion SPI
doesn't work without an LAContext
https://bugs.webkit.org/show_bug.cgi?id=225218

Attachment 427387: Patch

https://bugs.webkit.org/attachment.cgi?id=427387&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 427387
  --> https://bugs.webkit.org/attachment.cgi?id=427387
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427387&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:146
> +    if (shouldUseAlternateAttributes() && !context) {

Looks like we should have noticed that this path didn't match the other
verifyUser. :-( Looks good.