[webkit-reviews] review granted: [Bug 224550] Use OptionSet for MediaProducer::MutedStateFlags : [Attachment 427420] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 224550: Use OptionSet for MediaProducer::MutedStateFlags
https://bugs.webkit.org/show_bug.cgi?id=224550

Attachment 427420: Patch

https://bugs.webkit.org/attachment.cgi?id=427420&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 427420
  --> https://bugs.webkit.org/attachment.cgi?id=427420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427420&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1018
> -	   mutedState = WebCore::MediaProducer::AudioCaptureIsMuted;
> +	  
mutedState.add(WebCore::MediaProducer::MutedState::AudioCaptureIsMuted);

It looks like this fixes a potential bug, nice!

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1039
> -	   mutedState = WebCore::MediaProducer::VideoCaptureIsMuted;
> +	  
mutedState.add(WebCore::MediaProducer::MutedState::VideoCaptureIsMuted);

Ditto