[webkit-reviews] review granted: [Bug 222540] [Tools] Make run-buildbot-test compatible with buildbot 2.10.5 : [Attachment 427397] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 30 09:37:15 PDT 2021
Aakash Jain <aakash_jain at apple.com> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 222540: [Tools] Make run-buildbot-test compatible with buildbot 2.10.5
https://bugs.webkit.org/show_bug.cgi?id=222540
Attachment 427397: Patch
https://bugs.webkit.org/attachment.cgi?id=427397&action=review
--- Comment #13 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 427397
--> https://bugs.webkit.org/attachment.cgi?id=427397
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=427397&action=review
Looks good overall.
> Tools/ChangeLog:24
> + * CISupport/start-buildbot-server-test: Added.
I don't like the word 'test' in this filename, it makes it feel like this file
contains some kind of tests (unit-test or regression test). But file name
doesn't need to block this patch. We can rename it in subsequent patch.
More information about the webkit-reviews
mailing list