[webkit-reviews] review granted: [Bug 224533] [GTK][WPE] Properly recover from unresponsive web processes : [Attachment 427401] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Miguel Gomez
<magomez at igalia.com>'s request for review:
Bug 224533: [GTK][WPE] Properly recover from unresponsive web processes
https://bugs.webkit.org/show_bug.cgi?id=224533

Attachment 427401: Patch

https://bugs.webkit.org/attachment.cgi?id=427401&action=review




--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 427401
  --> https://bugs.webkit.org/attachment.cgi?id=427401
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427401&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4763
> + * signal is emitted with WEBKIT_WEB_PROCESS_REQUESTED_BY_API as the reason
for

WEBKIT_WEB_PROCESS_REQUESTED_BY_API -> %WEBKIT_WEB_PROCESS_REQUESTED_BY_API

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:1561
> +    g_signal_connect_after(test->m_webView, "web-process-terminated",
G_CALLBACK(WebViewTerminateWebProcessTest::webProcessTerminatedCallback),
test);

I would connect to the signal from the WebViewTerminateWebProcessTest
constructor

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:1570
> +    g_signal_handlers_disconnect_by_func(test->m_webView,
reinterpret_cast<void*>(WebViewTerminateWebProcessTest::webProcessTerminatedCal
lback), test);

And disconnect from the destructor using g_signal_handlers_disconnect_by_data

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:1586
> +    g_signal_connect_after(test->m_webView, "web-process-terminated",
G_CALLBACK(WebViewTerminateWebProcessTest::webProcessTerminatedCallback),
test);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:1606
> +    g_signal_handlers_disconnect_by_func(test->m_webView,
reinterpret_cast<void*>(WebViewTerminateWebProcessTest::webProcessTerminatedCal
lback), test);

Ditto.