[webkit-reviews] review granted: [Bug 225223] Optimize SortedArrayMap by using linear search for small arrays : [Attachment 427396] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 29 22:02:01 PDT 2021


Yusuke Suzuki <ysuzuki at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 225223: Optimize SortedArrayMap by using linear search for small arrays
https://bugs.webkit.org/show_bug.cgi?id=225223

Attachment 427396: Patch

https://bugs.webkit.org/attachment.cgi?id=427396&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 427396
  --> https://bugs.webkit.org/attachment.cgi?id=427396
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427396&action=review

r=me

> Source/WTF/wtf/SortedArrayMap.h:145
> +    if (std::size(m_array) < binarySearchThreshold) {

How about making it `if constexpr` to ensure that this dispatching is done at
compile time.

> Source/WTF/wtf/SortedArrayMap.h:177
> +    if (std::size(m_array) < binarySearchThreshold)

Ditto.


More information about the webkit-reviews mailing list