[webkit-reviews] review granted: [Bug 225208] REGRESSION (r275431): [iOS] fast/events/touch/ios/mouse-events-dispatch-with-touch.html is timing out : [Attachment 427374] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 225208: REGRESSION (r275431): [iOS]
fast/events/touch/ios/mouse-events-dispatch-with-touch.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=225208

Attachment 427374: Patch

https://bugs.webkit.org/attachment.cgi?id=427374&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 427374
  --> https://bugs.webkit.org/attachment.cgi?id=427374
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427374&action=review

r=me

> Source/WebCore/ChangeLog:13
> +	   Remove the `!needsQuirks()` check added in r275431 to restore the
> +	   original test behavior.

Might be worth expanding on this a bit more by saying that the test overrides
`MouseEventsSimulationEnabled` which is the first thing checked _before_
`needsQuirks()` inside `Quirks::shouldDispatchSimulatedMouseEvents` (and I
could be wrong on this part, but also that `NeedsSiteSpecificQuirks` defaults
to `false` in WebCore).