[webkit-reviews] review granted: [Bug 222685] Metal-ANGLE: Shared memory texture tests failing in iOS Simulator : [Attachment 427369] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 222685: Metal-ANGLE: Shared memory texture tests failing in iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=222685

Attachment 427369: Patch

https://bugs.webkit.org/attachment.cgi?id=427369&action=review




--- Comment #16 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 427369
  --> https://bugs.webkit.org/attachment.cgi?id=427369
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427369&action=review

Still looks good; two small suggestions.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:325
> +angle::Result CopyCompressedTextureContentsToStagingBuffer(

Same comment as before about considering unifying these entry points with a
bool argument.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:502
> +    //Copy to staging buffer before uploading to texture.

Space after "//"; also suggest putting these comments inside the if/else blocks
to make them easier to read.