[webkit-reviews] review granted: [Bug 225170] Adopt AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification : [Attachment 427314] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 225170: Adopt
AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification
https://bugs.webkit.org/show_bug.cgi?id=225170

Attachment 427314: Patch

https://bugs.webkit.org/attachment.cgi?id=427314&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 427314
  --> https://bugs.webkit.org/attachment.cgi?id=427314
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427314&action=review

> Source/WebCore/ChangeLog:11
> +	   The current handling of
AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification is currently
broken

s/The current handling/The handling/

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:974
> +    if (!trackId.isEmpty())
> +	   reenqueSamples(trackId);

It might be worth logging an error if the track id isn't found.