[webkit-reviews] review granted: [Bug 222918] Align internal methods of WindowProperties object with the spec : [Attachment 427313] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 222918: Align internal methods of WindowProperties object with the spec
https://bugs.webkit.org/show_bug.cgi?id=222918

Attachment 427313: Patch

https://bugs.webkit.org/attachment.cgi?id=427313&action=review




--- Comment #7 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 427313
  --> https://bugs.webkit.org/attachment.cgi?id=427313
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427313&action=review

> Source/WebCore/bindings/js/JSDOMWindowProperties.cpp:138
> +    return typeError(lexicalGlobalObject, scope, shouldThrow, "Unable to
define a property on a WindowProperties object."_s);

This error message reads a little weird to me. Maybe, "Defining a property on a
WindowProperties is not allowed." or something like that to indicate it is not
just failing because something went wrong, but we are actively preventing this
on purpose?

> LayoutTests/imported/w3c/ChangeLog:7
> +

Are test changes here from upstream or do you plan to upstream them?