[webkit-reviews] review granted: [Bug 225173] Add support for CanvasRenderingContext2DSettings : [Attachment 427322] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 225173: Add support for CanvasRenderingContext2DSettings
https://bugs.webkit.org/show_bug.cgi?id=225173

Attachment 427322: Patch

https://bugs.webkit.org/attachment.cgi?id=427322&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 427322
  --> https://bugs.webkit.org/attachment.cgi?id=427322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427322&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.idl:31
> +    // boolean alpha = true;

Not sure why we are commenting this out. I don't see the drawback for fully
matching the spec on IDL side (and even in the implementation struct). It's not
like the JS can feature-detect if we support a particular dictionary member of
not.
I personally think we should have alpha in the dictionary and the
implementation struct, and add a FIXME comment at the spot where the alpha
struct member should be used (but isn't yet).