[webkit-reviews] review granted: [Bug 225081] Use ImageBuffer scaling in RemoteLayerBackingStore, rather than handling scale in the class : [Attachment 427324] Patch

[bugzilla-daemon at webkit.org]

Said Abou-Hallawa <sabouhallawa at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 225081: Use ImageBuffer scaling in RemoteLayerBackingStore, rather than
handling scale in the class
https://bugs.webkit.org/show_bug.cgi?id=225081

Attachment 427324: Patch

https://bugs.webkit.org/attachment.cgi?id=427324&action=review




--- Comment #8 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 427324
  --> https://bugs.webkit.org/attachment.cgi?id=427324
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427324&action=review

>
Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:131
> +    m_context->applyDeviceScaleFactor(resolutionScale());

I think this is fine. Splitting the context setup between here and
ShareableBitmap::createGraphicsContext() seems inconsistent with IOSurface and
CGBitamp backends. So maybe in the future we need to call setupContext() for
all CG contexts instead.