[webkit-reviews] review granted: [Bug 225015] Block sizing is miscalculated for elements with a preferred aspect-ratio when padding is applied, and content can overflow. : [Attachment 427273] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 225015: Block sizing is miscalculated for elements with a preferred
aspect-ratio when padding is applied, and content can overflow.
https://bugs.webkit.org/show_bug.cgi?id=225015

Attachment 427273: Patch

https://bugs.webkit.org/attachment.cgi?id=427273&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 427273
  --> https://bugs.webkit.org/attachment.cgi?id=427273
Patch

Looks OK.

But there are multiple code changes and only one test case. Seems like we need
more test cases. When I see branches in code I assume each needs a different
test, so this seems to require at *least* 3 tests, but maybe more if we want to
cover not changing the cases we don’t want to.