[webkit-reviews] review granted: [Bug 225139] [clang] Remove implicit cast related warnings : [Attachment 427239] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 28 11:27:01 PDT 2021

Darin Adler <darin at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 225139: [clang] Remove implicit cast related warnings

Attachment 427239: PATCH


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 427239
  --> https://bugs.webkit.org/attachment.cgi?id=427239

View in context: https://bugs.webkit.org/attachment.cgi?id=427239&action=review

>> Source/WebCore/layout/inlineformatting/InlineLine.cpp:490
>> +	ASSERT(logicalWidth() > 0 || (!logicalWidth() &&
style().letterSpacing() >= static_cast<float>(intMaxForLayoutUnit)));
> The cast here is OK, but this code is really strange.

I would like someone to explain this assertion at some point.

More information about the webkit-reviews mailing list