[webkit-reviews] review granted: [Bug 225154] Add SPI to query whether a URL would be upgraded to HTTPS : [Attachment 427271] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225154: Add SPI to query whether a URL would be upgraded to HTTPS
https://bugs.webkit.org/show_bug.cgi?id=225154

Attachment 427271: Patch

https://bugs.webkit.org/attachment.cgi?id=427271&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 427271
  --> https://bugs.webkit.org/attachment.cgi?id=427271
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427271&action=review

r=me -- but let's consider another name

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:249
> ++ (BOOL)_shouldUpgradeToHTTPS:(NSURL *)url
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

I think I would call this _willUpgradeToHTTPS, since it's a question about what
the WebView will do.