[webkit-reviews] review granted: [Bug 225143] When IPC testing API is enabled, GPU process shouldn't kill Web Process : [Attachment 427246] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 225143: When IPC testing API is enabled, GPU process shouldn't kill Web
Process
https://bugs.webkit.org/show_bug.cgi?id=225143

Attachment 427246: Patch

https://bugs.webkit.org/attachment.cgi?id=427246&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 427246
  --> https://bugs.webkit.org/attachment.cgi?id=427246
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427246&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:336
> +    if (connection.ignoreInvalidMessageForTesting())

Do we want to do that before the RELEASE_LOG_FAULT since RELEASE_LOG_FAULT
generates a simulated crash trace (on iOS at least)?