[webkit-reviews] review granted: [Bug 225075] [selectors] Using a modifier key on an element makes it stop matching :focus-visible : [Attachment 427238] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 28 00:18:52 PDT 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 225075: [selectors] Using a modifier key on an element makes it stop
matching :focus-visible
https://bugs.webkit.org/show_bug.cgi?id=225075

Attachment 427238: Patch

https://bugs.webkit.org/attachment.cgi?id=427238&action=review




--- Comment #15 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 427238
  --> https://bugs.webkit.org/attachment.cgi?id=427238
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427238&action=review

> Source/WebCore/dom/Element.cpp:750
> +    // Elements that support keyboard input (form inputs and
contenteditable) always match :focus-visible when focused.

This comment now just repeats what the code says so please remove.


More information about the webkit-reviews mailing list