[webkit-reviews] review granted: [Bug 225117] IPC::decoder::decode() should mark decoder as invalid when failing : [Attachment 427189] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 225117: IPC::decoder::decode() should mark decoder as invalid when failing
https://bugs.webkit.org/show_bug.cgi?id=225117

Attachment 427189: Patch

https://bugs.webkit.org/attachment.cgi?id=427189&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 427189
  --> https://bugs.webkit.org/attachment.cgi?id=427189
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427189&action=review

> Source/WebKit/ChangeLog:10
> +	   IPC::decoder::decode() should mark decoder as invalid when failing,
instead of relying
> +	   on individual type decoders to do so. This makes type decoders a bit
simpler and less
> +	   error-prone.

Seems like the risk here is if any caller was calling an individual type
decoder directly. If it was, then the markInvalid no longer happens.

Benefit is very high, I definitely approve of this idea.