[webkit-reviews] review granted: [Bug 225009] Web Inspector: Default Audits script are minified in release builds : [Attachment 427159] Patch v1.1 - Added test, review notes

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 225009: Web Inspector: Default Audits script are minified in release builds
https://bugs.webkit.org/show_bug.cgi?id=225009

Attachment 427159: Patch v1.1 - Added test, review notes

https://bugs.webkit.org/attachment.cgi?id=427159&action=review




--- Comment #6 from BJ Burg <bburg at apple.com> ---
Comment on attachment 427159
  --> https://bugs.webkit.org/attachment.cgi?id=427159
Patch v1.1 - Added test, review notes

View in context: https://bugs.webkit.org/attachment.cgi?id=427159&action=review

r=me, this is excellent!

> Source/WebInspectorUI/ChangeLog:14
> +	   important to the script. For example, the source for the default
audits are visible to the user, and therefor we

Nit: therefore

> Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:386
> +		   new WI.AuditTestCase("testMenuRoleForRequiredChildren",
WI.DefaultAudits.testMenuRoleForRequiredChildren.toString(), {description:
WI.UIString("Ensure that elements of role \u0022%s\u0022 and \u0022%s\u0022
have required owned elements in accordance with
WAI-ARIA.").format(WI.unlocalizedString("menu"),
WI.unlocalizedString("menubar")), supports: 1}),

It's rather unfortunate that we have to stringify the functions at every call
site.

> LayoutTests/inspector/audit/non-minified-default-audits.html:8
> +    let suite =
InspectorTest.createAsyncSuite("Audit.NonMinifiedDefaultAudits");

Nice!