[webkit-reviews] review granted: [Bug 225099] [WPE][GTK] More correct fixes for stack size issues on musl libc : [Attachment 427144] fixed style, typos

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Daniel Kolesa <dkolesa at igalia.com>'s
request for review:
Bug 225099: [WPE][GTK] More correct fixes for stack size issues on musl libc
https://bugs.webkit.org/show_bug.cgi?id=225099

Attachment 427144: fixed style, typos

https://bugs.webkit.org/attachment.cgi?id=427144&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 427144
  --> https://bugs.webkit.org/attachment.cgi?id=427144
fixed style, typos

View in context: https://bugs.webkit.org/attachment.cgi?id=427144&action=review

r=me with suggestion for USE(MUSL).  Feel free to do that as clean up in a
follow up patch.

> Source/WTF/wtf/StackBounds.cpp:117
> +#if OS(LINUX) && !defined(__BIONIC__) && !defined(__GLIBC__)

I see this set of conditionals used in more than 1 place (3 in this patch). 
Would it be better to define USE_MUSL in PlatformUse.h and check #if USE(MUSL)
here (and in the other places)?  Is this code only needed for musl?