[webkit-reviews] review granted: [Bug 225089] HashTableConstIterator's consistency assertion fails while closing m_webIDBServers in NetworkProcess::didClose since r275846 : [Attachment 427124] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 225089: HashTableConstIterator's consistency assertion fails while closing
m_webIDBServers in NetworkProcess::didClose since r275846
https://bugs.webkit.org/show_bug.cgi?id=225089

Attachment 427124: Patch

https://bugs.webkit.org/attachment.cgi?id=427124&action=review




--- Comment #12 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 427124
  --> https://bugs.webkit.org/attachment.cgi?id=427124
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427124&action=review

Restoring r+, I personally think the patch is fine as is. Each WebIDBServer has
a closeCallback that get passed to it when constructed and which removes the
WebIDBServer from m_webIDBServers.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:278
> +	   m_webIDBServers.values().begin()->get()->close();

I am surprised you really need the `->get()` here.