[webkit-reviews] review denied: [Bug 225075] [selectors] Using a modifier key on an element makes it stop matching :focus-visible : [Attachment 427136] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 09:12:47 PDT 2021


Darin Adler <darin at apple.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 225075: [selectors] Using a modifier key on an element makes it stop
matching :focus-visible
https://bugs.webkit.org/show_bug.cgi?id=225075

Attachment 427136: Patch

https://bugs.webkit.org/attachment.cgi?id=427136&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 427136
  --> https://bugs.webkit.org/attachment.cgi?id=427136
Patch

Looks like tests are hitting assertion failures in Element::setHasFocusVisible.
Let’s review a version after this is fixed.


More information about the webkit-reviews mailing list