[webkit-reviews] review requested: [Bug 225099] [WPE][GTK] More correct fixes for stack size issues on musl libc : [Attachment 427141] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 06:31:09 PDT 2021

Daniel Kolesa <dkolesa at igalia.com> has asked  for review:
Bug 225099: [WPE][GTK] More correct fixes for stack size issues on musl libc

Attachment 427141: patch


--- Comment #1 from Daniel Kolesa <dkolesa at igalia.com> ---
Created attachment 427141

  --> https://bugs.webkit.org/attachment.cgi?id=427141&action=review


Some comments for potential review:

- I considered using WTF::isMainThread() but decided against it; since this
piece of code is specific to Linux, I thought it'd be best to use the lowest
level API in order to avoid abstractions potentially causing issues and stay
- Ideally I'd like to change the '#if OS(LINUX) && !defined(__BIONIC__) &&
!defined(__GLIBC__)' to just '#if OS(LINUX)' in StackBounds.cpp. Common paths
are better tested, and this should not hurt non-musl systems; finally, fewer
ifdefs are better than more. I included a strict conditional for now to be
conservative. I'll leave it up to reviewer which path we'll end up taking.

More information about the webkit-reviews mailing list