[webkit-reviews] review granted: [Bug 225097] [css-flexbox] Fix expectations of a WPT test that works fine : [Attachment 427135] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 225097: [css-flexbox] Fix expectations of a WPT test that works fine
https://bugs.webkit.org/show_bug.cgi?id=225097

Attachment 427135: Patch

https://bugs.webkit.org/attachment.cgi?id=427135&action=review




--- Comment #3 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 427135
  --> https://bugs.webkit.org/attachment.cgi?id=427135
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427135&action=review

r=me, please wait for having green EWSs before landing.

> LayoutTests/imported/w3c/ChangeLog:9
> +	   Fixed the paths of some images that were not properly converted
during import.

Is there a bug reported for the import script so this doesn't happen in the
future?

It looks like next time we use the script to re-import things, this change
might be overwritten.
Can we change the test in a way that we workaround the import script? Maybe
using full paths from "/" or something like that. And export that change into
WPT.
Mostly to avoid having the same issue next time we re-sync the tests.