[webkit-reviews] review granted: [Bug 225057] charset in contentType used in Blob.prototype.slice(start, end, contentType) is lost : [Attachment 427108] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225057: charset in contentType used in Blob.prototype.slice(start, end,
contentType) is lost
https://bugs.webkit.org/show_bug.cgi?id=225057

Attachment 427108: Patch

https://bugs.webkit.org/attachment.cgi?id=427108&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 427108
  --> https://bugs.webkit.org/attachment.cgi?id=427108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427108&action=review

> LayoutTests/fast/files/blob-content-type.html:5
> +    const blob = new Blob([`<style></style>`], { type:
'text/original-blob-content-type;' });

Why the weird ` quotes?

> LayoutTests/fast/files/blob-content-type.html:8
> +	   const slice = blob.slice(0, blob.size, `text/html2;charset=utf-8`);

ditto.

> LayoutTests/fast/files/blob-content-type.html:22
> +	   const slice = blob.slice(0, blob.size, "");

and then here double quotes, even though the rest of the file seems to be using
single quotes.