[webkit-reviews] review denied: [Bug 225067] Consistently include headers with <Framework/Header.h> : [Attachment 427074] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 26 14:17:51 PDT 2021
Alexey Proskuryakov <ap at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225067: Consistently include headers with <Framework/Header.h>
https://bugs.webkit.org/show_bug.cgi?id=225067
Attachment 427074: Patch
https://bugs.webkit.org/attachment.cgi?id=427074&action=review
--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 427074
--> https://bugs.webkit.org/attachment.cgi?id=427074
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=427074&action=review
> Source/WebCore/platform/ios/WebItemProviderPasteboard.h:26
> -#import <WebCore/AbstractPasteboard.h>
> +#import "AbstractPasteboard.h"
WebItemProviderPasteboard.h is a private header, so it needs to use framework
style includes for WebCore headers.
I didn't check the rest of the patch, please check it for other instances of
this.
More information about the webkit-reviews
mailing list