[webkit-reviews] review granted: [Bug 224980] REGRESSION (r271861): [iOS] Accessory bar navigation to elements outside the viewport fails : [Attachment 426913] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 224980: REGRESSION (r271861): [iOS] Accessory bar navigation to elements
outside the viewport fails
https://bugs.webkit.org/show_bug.cgi?id=224980

Attachment 426913: Patch

https://bugs.webkit.org/attachment.cgi?id=426913&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 426913
  --> https://bugs.webkit.org/attachment.cgi?id=426913
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426913&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2569
> +    constexpr OptionSet<HitTestRequest::RequestType> hitType {
HitTestRequest::ReadOnly, HitTestRequest::Active, 
HitTestRequest::AllowChildFrameContent,
HitTestRequest::DisallowUserAgentShadowContent, HitTestRequest::IgnoreClipping
};

Nit - it looks like this adds an extra leading space before
`HitTestRequest::AllowChildFrameContent`.