[webkit-reviews] review granted: [Bug 225048] Refcount Style::Resolver : [Attachment 427032] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 225048: Refcount Style::Resolver
https://bugs.webkit.org/show_bug.cgi?id=225048

Attachment 427032: patch

https://bugs.webkit.org/attachment.cgi?id=427032&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 427032
  --> https://bugs.webkit.org/attachment.cgi?id=427032
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427032&action=review

> Source/WebCore/style/StyleResolver.h:83
> +class Resolver : public RefCounted<Resolver> {
>  public:

Should we iso-heap this?

> Source/WebCore/style/StyleScope.h:180
>      HashSet<const Element*> m_elementsInHeadWithPendingSheets;
>      HashSet<const Element*> m_elementsInBodyWithPendingSheets;

Yikes. We should use WeakHashSet for these!

> Source/WebCore/style/StyleTreeResolver.h:73
>	   Scope* enclosingScope { nullptr };

Should this be RefPtr<Scope> as well?