[webkit-reviews] review granted: [Bug 225011] [Metal ANGLE] support primitive restart behavior with simple data types : [Attachment 426973] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 225011: [Metal ANGLE] support primitive restart behavior with simple data
types
https://bugs.webkit.org/show_bug.cgi?id=225011

Attachment 426973: Patch

https://bugs.webkit.org/attachment.cgi?id=426973&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 426973
  --> https://bugs.webkit.org/attachment.cgi?id=426973
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426973&action=review

> Source/ThirdParty/ANGLE/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=225011

Could you add the radar link in here?

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:418
> +    T *bufferData = (T*)(idxBuffer->mapReadOnly(ctx));

I'm not sure of ANGLE style, but wouldn't this be better as:

auto* bufferData = static_cast<T*>(idxBuffer->mapReadOnly(ctx));