[webkit-reviews] review granted: [Bug 225028] Deploy Ref/RefPtr in DeleteSelectionCommand : [Attachment 426995] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 24 19:30:19 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 225028: Deploy Ref/RefPtr in DeleteSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=225028

Attachment 426995: Patch

https://bugs.webkit.org/attachment.cgi?id=426995&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 426995
  --> https://bugs.webkit.org/attachment.cgi?id=426995
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426995&action=review

r=mews

> Source/WebCore/editing/DeleteSelectionCommand.cpp:1044
> +	       Text& textNode = downcast<Text>(*endNode);

Nit - auto& here.


More information about the webkit-reviews mailing list