[webkit-reviews] review granted: [Bug 224941] Crash in BreakBlockquoteCommand::doApply() : [Attachment 426945] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Julian Gonzalez
<julian_a_gonzalez at apple.com>'s request for review:
Bug 224941: Crash in BreakBlockquoteCommand::doApply()
https://bugs.webkit.org/show_bug.cgi?id=224941

Attachment 426945: Patch

https://bugs.webkit.org/attachment.cgi?id=426945&action=review




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 426945
  --> https://bugs.webkit.org/attachment.cgi?id=426945
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426945&action=review

> Source/WebCore/editing/BreakBlockquoteCommand.cpp:112
> +	       if (auto nextNode = NodeTraversal::next(*startNode))

This is a bit misleading. This should be either auto* or we should be calling
makeRefPtr & WTFMove(nextNode) below

> Source/WebCore/editing/BreakBlockquoteCommand.cpp:117
> +	   if (auto child =
startNode->traverseToChildAt(pos.deprecatedEditingOffset()))

Ditto.

> Source/WebCore/editing/BreakBlockquoteCommand.cpp:119
> +	   else if (auto next = NodeTraversal::next(*startNode))

Ditto.