[webkit-reviews] review granted: [Bug 225003] ANGLE X11 build fixes : [Attachment 426957] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 23 17:56:23 PDT 2021

Kenneth Russell <kbr at google.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 225003: ANGLE X11 build fixes

Attachment 426957: Patch


--- Comment #2 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 426957
  --> https://bugs.webkit.org/attachment.cgi?id=426957

View in context: https://bugs.webkit.org/attachment.cgi?id=426957&action=review

Seems fine. r+

> Source/WebCore/platform/graphics/angle/ANGLEHeaders.h:52
> +#if defined(None)

Would it be possible to put some guard around this entire block so it only
applies to X11 platforms? If not, that's OK.

More information about the webkit-reviews mailing list