[webkit-reviews] review granted: [Bug 224991] [Metal ANGLE] Temporarily remove AST validation even for debug builds : [Attachment 426937] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted John Cunningham
<johncunningham at apple.com>'s request for review:
Bug 224991: [Metal ANGLE] Temporarily remove AST validation even for debug
builds
https://bugs.webkit.org/show_bug.cgi?id=224991

Attachment 426937: Patch

https://bugs.webkit.org/attachment.cgi?id=426937&action=review




--- Comment #6 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 426937
  --> https://bugs.webkit.org/attachment.cgi?id=426937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426937&action=review

Thanks for the explanation. r+

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm:88
> +#if defined(ANGLE_ENABLE_ASSERTS) && 0

Please add some TODO here regarding moving this validation in the future so we
don't forget it.