[webkit-reviews] review granted: [Bug 224718] [css-counter-styles] Parse @counter-style descriptors : [Attachment 426858] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 22 22:07:30 PDT 2021
Darin Adler <darin at apple.com> has granted Tyler Wilcock
<twilco.o at protonmail.com>'s request for review:
Bug 224718: [css-counter-styles] Parse @counter-style descriptors
https://bugs.webkit.org/show_bug.cgi?id=224718
Attachment 426858: Patch
https://bugs.webkit.org/attachment.cgi?id=426858&action=review
--- Comment #21 from Darin Adler <darin at apple.com> ---
Comment on attachment 426858
--> https://bugs.webkit.org/attachment.cgi?id=426858
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=426858&action=review
> Source/WebCore/css/CSSCounterStyleRule.cpp:224
> + auto tokenRange = tokenizer.tokenRange();
Would be better without a local variable for tokenRange?
> Source/WebCore/css/CSSCounterStyleRule.cpp:236
> + auto tokenRange = tokenizer.tokenRange();
Would be better without a local variable for tokenRange?
More information about the webkit-reviews
mailing list