[webkit-reviews] review granted: [Bug 224964] [JSC][Win] callOperationNoExceptionCheck() also needs to support operations that return SlowPathReturnType : [Attachment 426882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 21:41:58 PDT 2021


Yusuke Suzuki <ysuzuki at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 224964: [JSC][Win] callOperationNoExceptionCheck() also needs to support
operations that return SlowPathReturnType
https://bugs.webkit.org/show_bug.cgi?id=224964

Attachment 426882: Patch

https://bugs.webkit.org/attachment.cgi?id=426882&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 426882
  --> https://bugs.webkit.org/attachment.cgi?id=426882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426882&action=review

r=me

> Source/JavaScriptCore/jit/JIT.h:827
> +	   template<typename Type> static const bool is64BitType = sizeof(Type)
<= 8;

Use static constexpr instead of static const


More information about the webkit-reviews mailing list