[webkit-reviews] review granted: [Bug 224958] Add an option to not enable all experimental features in WebKitTestRunner : [Attachment 426865] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 17:05:48 PDT 2021


Tim Horton <thorton at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 224958: Add an option to not enable all experimental features in
WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=224958

Attachment 426865: Patch

https://bugs.webkit.org/attachment.cgi?id=426865&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 426865
  --> https://bugs.webkit.org/attachment.cgi?id=426865
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426865&action=review

> Tools/WebKitTestRunner/TestController.h:542
> +    bool m_enableAllExperimentalFeatures { false };

Humorous and confusing that the default is different here (I assume it gets
plumbed from Options?)


More information about the webkit-reviews mailing list