[webkit-reviews] review granted: [Bug 224956] [iOS] GPU Process sandbox lacks IOMobileFramebufferUserClient method filter : [Attachment 426863] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 224956: [iOS] GPU Process sandbox lacks IOMobileFramebufferUserClient
method filter
https://bugs.webkit.org/show_bug.cgi?id=224956

Attachment 426863: Patch

https://bugs.webkit.org/attachment.cgi?id=426863&action=review




--- Comment #2 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 426863
  --> https://bugs.webkit.org/attachment.cgi?id=426863
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426863&action=review

R=me.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:96
> +		      (allow (with telemetry) (with message
"IOMobileFramebufferUserClient")

Is the telemetry needed on the allow rule? Sometimes telemetry for frequently
hit rules can cause a perf regression.