[webkit-reviews] review granted: [Bug 224927] Handle rotation correctly in WebRTC GPUProcess rendering pipeline : [Attachment 426802] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 11:37:18 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 224927: Handle rotation correctly in WebRTC GPUProcess rendering pipeline
https://bugs.webkit.org/show_bug.cgi?id=224927

Attachment 426802: Patch

https://bugs.webkit.org/attachment.cgi?id=426802&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 426802
  --> https://bugs.webkit.org/attachment.cgi?id=426802
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426802&action=review

> Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:81
> -    m_sampleBufferDisplayLayer->updateAffineTransform(transform);
> +    m_sampleBufferDisplayLayer->updateRootLayerAffineTransform(transform);

Why don't we have to do this in the web process? 

What happens in the web process if `updateAffineTransform`to rotates the root
layer?


More information about the webkit-reviews mailing list