[webkit-reviews] review granted: [Bug 224897] Disable GPUProcess on shipping iOS : [Attachment 426820] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 22 11:13:54 PDT 2021


Tim Horton <thorton at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 224897: Disable GPUProcess on shipping iOS
https://bugs.webkit.org/show_bug.cgi?id=224897

Attachment 426820: Patch

https://bugs.webkit.org/attachment.cgi?id=426820&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 426820
  --> https://bugs.webkit.org/attachment.cgi?id=426820
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426820&action=review

Why build-time instead of run-time?

> Source/WTF/wtf/PlatformEnableCocoa.h:223
> +#if PLATFORM(MAC) \

I think you still want the !defined() check


More information about the webkit-reviews mailing list